From mboxrd@z Thu Jan  1 00:00:00 1970
From: okaya@codeaurora.org (okaya@codeaurora.org)
Date: Tue, 08 May 2018 01:21:38 +0100
Subject: AER: Malformed TLP recovery deadlock with NVMe drives
In-Reply-To: <3d4991bc2948430d910a16da36c90b91@ausx13mps321.AMER.DELL.COM>
References: <8cf4e563-5f84-f8bd-88a6-8369cdf07b29@gmail.com>
 <7afd280ad80a73b39e6c9b9a9e29abcc@codeaurora.org>
 <5c97a7c2-cb53-4740-fda0-50ba92288c5c@gmail.com>
 <9fc90040d5712282ea223807ace39312@codeaurora.org>
 <1125ddf8-f342-3f8f-90ee-0aa94287360c@gmail.com>
 <16bdb0febb842ad0980db9214c8076c5@codeaurora.org>
 <3d4991bc2948430d910a16da36c90b91@ausx13mps321.AMER.DELL.COM>
Message-ID: <1fdfaaa47ad782ee864f24c5a75a355a@codeaurora.org>

On 2018-05-08 00:57, Alex_Gagniuc@Dellteam.com wrote:
> On 5/7/2018 5:46 PM, okaya@codeaurora.org wrote:
> [snip]
>>> If it were easy, somebody would have patched it by now ;)
>> 
>> Can you file a bugzilla CC me, keith and bjorn and attach all of your
>> logs?
> 
> Sure. Which bugzilla?
> 

https://bugzilla.kernel.org

Drivers -> pci


> 
>> Let's debug this there.
> 

Bugzilla is more organized for keeping track of which log is for what.

My experience is that bugzilla is preferred unless Keith or Bjorn has a 
different opinion.

> Debugging over email not fun enough?
> 
> Alex
> 
> 
>>>> With this patch, you shouldn't
>>>> see link down and up interrupts during reset but i do see them in 
>>>> the
>>>> log.
>>> 
>>> You will see the messages from the link up/down events regardless if
>>> any
>>> action is actually taken.
>>> 
>>>> Can you also share a fail case log with this patch and a diff of 
>>>> your
>>>> hacks so that we know where prints are coming from.
>>> 
>>> Of course. Example of failing case [3], and is identical to the fail
>>> log
>>> without any patches. Although prints have the function name, the diff
>>> is
>>> in [4].
>>> 
>>> Alex
>>> 
>>> [3] http://gtech.myftp.org/~mrnuke/nvme_logs/log-20180507-1509.log
>>> [4] http://gtech.myftp.org/~mrnuke/nvme_logs/print_hacks.patch
>>> 
>>> 
>>>>> [2] http://gtech.myftp.org/~mrnuke/nvme_logs/log-20180507-1429.log
>>>>>>> [1] 
>>>>>>> http://gtech.myftp.org/~mrnuke/nvme_logs/log-20180507-1308.log
>>