From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH] NVMe: Set request queue logical block size
Date: Tue, 24 Jul 2012 15:55:32 -0400 [thread overview]
Message-ID: <20120724195532.GA22985@linux.intel.com> (raw)
In-Reply-To: <B58D82457FDA0744A320A2FC5AC253B90D438980@FMSMSX105.amr.corp.intel.com>
On Tue, Jul 24, 2012@07:26:14PM +0000, Busch, Keith wrote:
> Sets the request queue logical block size with the block size of the namespace.
No objection to the patch itself, but it looks like you used Outlook to
send it. Outlook has a nasty habit of corrupting patches, even if you
attach them. Can you resend with a different MUA?
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/block/nvme.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/block/nvme.c b/drivers/block/nvme.c
> index f4996b0..38b9c73 100644
> --- a/drivers/block/nvme.c
> +++ b/drivers/block/nvme.c
> @@ -1344,6 +1344,7 @@ static struct nvme_ns *nvme_alloc_ns(struct nvme_dev *dev, int nsid,
> ns->disk = disk;
> lbaf = id->flbas & 0xf;
> ns->lba_shift = id->lbaf[lbaf].ds;
> + blk_queue_logical_block_size(ns->queue, 1 << ns->lba_shift);
> disk->major = nvme_major;
> disk->minors = NVME_MINORS;
> --
> 1.7.0.4
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://merlin.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2012-07-24 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 19:26 [PATCH] NVMe: Set request queue logical block size Busch, Keith
2012-07-24 19:55 ` Matthew Wilcox [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-24 21:01 Keith Busch
2012-07-25 15:59 Keith Busch
2012-07-25 18:56 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120724195532.GA22985@linux.intel.com \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).