[PATCH] NVMe: Set request queue logical block size

[PATCH] NVMe: Set request queue logical block size

[Busch, Keith]

Sets the request queue logical block size with the block size of the namespace.

Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/block/nvme.c |    1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/block/nvme.c b/drivers/block/nvme.c
index f4996b0..38b9c73 100644
--- a/drivers/block/nvme.c
+++ b/drivers/block/nvme.c
@@ -1344,6 +1344,7 @@ static struct nvme_ns *nvme_alloc_ns(struct nvme_dev *dev, int nsid,
     ns->disk = disk;
     lbaf = id->flbas & 0xf;
     ns->lba_shift = id->lbaf[lbaf].ds;
+     blk_queue_logical_block_size(ns->queue, 1 << ns->lba_shift);
      disk->major = nvme_major;
     disk->minors = NVME_MINORS;
--
1.7.0.4

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://merlin.infradead.org/pipermail/linux-nvme/attachments/20120724/cf1a7436/attachment.html>

[PATCH] NVMe: Set request queue logical block size

[Matthew Wilcox]

On Tue, Jul 24, 2012@07:26:14PM +0000, Busch, Keith wrote:
> Sets the request queue logical block size with the block size of the namespace.

No objection to the patch itself, but it looks like you used Outlook to
send it.  Outlook has a nasty habit of corrupting patches, even if you
attach them.  Can you resend with a different MUA?

> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/block/nvme.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/block/nvme.c b/drivers/block/nvme.c
> index f4996b0..38b9c73 100644
> --- a/drivers/block/nvme.c
> +++ b/drivers/block/nvme.c
> @@ -1344,6 +1344,7 @@ static struct nvme_ns *nvme_alloc_ns(struct nvme_dev *dev, int nsid,
>      ns->disk = disk;
>      lbaf = id->flbas & 0xf;
>      ns->lba_shift = id->lbaf[lbaf].ds;
> +     blk_queue_logical_block_size(ns->queue, 1 << ns->lba_shift);
>       disk->major = nvme_major;
>      disk->minors = NVME_MINORS;
> --
> 1.7.0.4
> 

> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://merlin.infradead.org/mailman/listinfo/linux-nvme

[PATCH] NVMe: Set request queue logical block size

[Keith Busch]

From: Keith Busch <keith.busch@intel.com>

Sets the request queue logical block size with the block size of the namespace.

Signed-off-by: Keith Busch <keith.busch at intel.com>
---
 drivers/block/nvme.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/block/nvme.c b/drivers/block/nvme.c
index f4996b0..38b9c73 100644
--- a/drivers/block/nvme.c
+++ b/drivers/block/nvme.c
@@ -1344,6 +1344,7 @@ static struct nvme_ns *nvme_alloc_ns(struct nvme_dev *dev, int nsid,
 	ns->disk = disk;
 	lbaf = id->flbas & 0xf;
 	ns->lba_shift = id->lbaf[lbaf].ds;
+	blk_queue_logical_block_size(ns->queue, 1 << ns->lba_shift);
 
 	disk->major = nvme_major;
 	disk->minors = NVME_MINORS;
-- 
1.7.1

[PATCH] NVMe: Set request queue logical block size

[Keith Busch]

Sets the request queue logical block size with the block size of the namespace.

Signed-off-by: Keith Busch <keith.busch at intel.com>
---
 drivers/block/nvme.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/block/nvme.c b/drivers/block/nvme.c
index f4996b0..38b9c73 100644
--- a/drivers/block/nvme.c
+++ b/drivers/block/nvme.c
@@ -1344,6 +1344,7 @@ static struct nvme_ns *nvme_alloc_ns(struct nvme_dev *dev, int nsid,
 	ns->disk = disk;
 	lbaf = id->flbas & 0xf;
 	ns->lba_shift = id->lbaf[lbaf].ds;
+	blk_queue_logical_block_size(ns->queue, 1 << ns->lba_shift);
 
 	disk->major = nvme_major;
 	disk->minors = NVME_MINORS;
-- 
1.7.1

[PATCH] NVMe: Set request queue logical block size

[Matthew Wilcox]

On Wed, Jul 25, 2012@09:59:23AM -0600, Keith Busch wrote:
> Sets the request queue logical block size with the block size of the namespace.

Thanks!  Committed & pushed.