From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH] Dynamically allocate partition numbers
Date: Tue, 10 Dec 2013 09:49:01 -0500 [thread overview]
Message-ID: <20131210144901.GI6900@linux.intel.com> (raw)
In-Reply-To: <52A6F712.7010308@bjorling.me>
On Tue, Dec 10, 2013@12:12:18PM +0100, Matias Bj?rling wrote:
> >@@ -1975,12 +1947,13 @@ static struct nvme_ns *nvme_alloc_ns(struct nvme_dev *dev, unsigned nsid,
> > blk_queue_max_hw_sectors(ns->queue, dev->max_hw_sectors);
> >
> > disk->major = nvme_major;
> >- disk->minors = NVME_MINORS;
> >- disk->first_minor = NVME_MINORS * nvme_get_ns_idx();
> >+ disk->minors = 0;
>
> The above line can be removed.
Hm, yeah, good point, alloc_disk() initialises ->minors, and always has,
so we didn't need to initialise it before either. I'll take that line
out before committing.
> Tested and works.
I'll add your tested-by. I tested it myself with about 80 partitions.
prev parent reply other threads:[~2013-12-10 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 17:58 [PATCH] Dynamically allocate partition numbers Matthew Wilcox
2013-12-10 11:12 ` Matias Bjørling
2013-12-10 14:49 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210144901.GI6900@linux.intel.com \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).