linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH RFC 3/5] NVMe: Asynchronous device scan support
Date: Sun, 13 Apr 2014 13:42:28 -0400	[thread overview]
Message-ID: <20140413174228.GQ5727@linux.intel.com> (raw)
In-Reply-To: <20140411135901.GM5727@linux.intel.com>

On Fri, Apr 11, 2014@09:59:01AM -0400, Matthew Wilcox wrote:
> For motivation, I have a device here which erroneously reports that it
> has billions of namespaces.  Every time I forget to include the patch to
> change 'nn' to 1 for that PCI device ID, the driver sends billions of
> IDENTIFY NAMESPACE commands to that device.  While I wait for that to
> happen, it gives me plenty of time to look at the system and think about
> the consequences of the code we have today :-)

By the way, this patch looks like a good start on tackling the problem:

http://lists.infradead.org/pipermail/linux-nvme/2013-September/000470.html

Some of the infrastructure it adds is already present, eg
nvme_submit_admin_cmd_async().  Allocating one discovery event per
namespace seems like a bad idea; since we can't have more than 64 admin
commands in flight, it would seem reasonable to limit the number of
disco events that can be outstanding at any time.  With Keith's example
2 million namespaces, it was allocating 16GB of DMA consistent memory
... not too much of a problem on a typical dev box these days, but I
wouldn't like to be a NAS box.

P.S.: I am, though, greatly in favour of a free disco event.  Perhaps we
can arrange one at a conference soon?

  reply	other threads:[~2014-04-13 17:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30 10:27 [PATCH RFC 0/5] NVMe: Hotplug support Santosh Y
2013-12-30 10:27 ` [PATCH RFC 1/5] NVMe: Code cleanup and minor checkpatch correction Santosh Y
2013-12-30 13:32   ` Matthew Wilcox
2013-12-30 14:52   ` Keith Busch
2013-12-30 10:27 ` [PATCH RFC 2/5] NVMe: Basic NVMe device hotplug support Santosh Y
2013-12-30 13:46   ` Matthew Wilcox
2013-12-30 13:48   ` Matias Bjorling
2013-12-30 14:09   ` Matias Bjorling
2013-12-30 16:06   ` Keith Busch
2013-12-30 17:21   ` Keith Busch
2013-12-31  8:48     ` Ravi Kumar
2013-12-31 13:35   ` Matthew Wilcox
2013-12-31 17:17     ` Matthew Wilcox
2013-12-30 10:27 ` [PATCH RFC 3/5] NVMe: Asynchronous device scan support Santosh Y
2013-12-30 13:50   ` Matthew Wilcox
2013-12-30 15:55     ` Keith Busch
2014-03-28 14:02     ` Santosh Y
2014-03-28 16:29       ` Keith Busch
2014-04-11 13:59       ` Matthew Wilcox
2014-04-13 17:42         ` Matthew Wilcox [this message]
2013-12-30 10:27 ` [PATCH RFC 4/5] NVMe: Stale node cleanup based on reference count Santosh Y
2013-12-30 14:00   ` Matthew Wilcox
2013-12-30 10:27 ` [PATCH RFC 5/5] NVMe: Hotplug support during hibernate/sleep states Santosh Y

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140413174228.GQ5727@linux.intel.com \
    --to=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).