From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH] Remove redundant writes to uncached sqe memory
Date: Sat, 10 May 2014 22:54:55 -0400 [thread overview]
Message-ID: <20140511025455.GD6121@linux.intel.com> (raw)
In-Reply-To: <CAOu_J6ntbk=CxHLk-mea5Jkza=NFgomyZoGmFe+_Zg96tQN5_g@mail.gmail.com>
On Fri, May 09, 2014@11:14:46PM +0200, Matias Bj?rling wrote:
> I think a description above the declaration of struct nvme_rw_command
> would be helpful. E.g. "If you modify this structure, please change
> nvme_submit_iod accordingly to take care of initialization."
I don't think that's necessary. There's no hidden gaps in the definition
of nvme_rw_command, so the explicit initialisation of all the fields will
write all of the bytes in the command.
next prev parent reply other threads:[~2014-05-11 2:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 20:44 [PATCH] Remove redundant writes to uncached sqe memory Sam Bradshaw
2014-05-09 21:14 ` Matias Bjørling
2014-05-11 2:54 ` Matthew Wilcox [this message]
2014-05-11 2:52 ` Matthew Wilcox
2014-05-12 19:41 ` Sam Bradshaw (sbradshaw)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140511025455.GD6121@linux.intel.com \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox