From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH] NVMe: Create module parameter for shutdown timeout.
Date: Fri, 20 Jun 2014 13:15:52 -0400 [thread overview]
Message-ID: <20140620171552.GN12025@linux.intel.com> (raw)
In-Reply-To: <1403256174-3595-1-git-send-email-daniel.mcleran@intel.com>
On Fri, Jun 20, 2014@03:22:54AM -0600, Dan McLeran wrote:
> The current implementation hard-codes shutdown timeout to 2 seconds. Some devices take
> longer than this to successfully complete a normal shutdown. This patch creates a module
> parameter for shutdown timeout and sets the default to 5 seconds.
Those devices are broken. From the spec:
"It is recommended that the host wait a minimum of one second for the
shutdown operations to complete."
We're being generous and allowing them two seconds. Whoever's device
this is should fix it.
next prev parent reply other threads:[~2014-06-20 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 9:22 [PATCH] NVMe: Create module parameter for shutdown timeout Dan McLeran
2014-06-20 17:15 ` Matthew Wilcox [this message]
2014-06-20 17:26 ` Mayes, Barrett N
2014-06-20 18:34 ` Mayes, Barrett N
2014-06-28 13:00 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620171552.GN12025@linux.intel.com \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox