Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH] NVMe: Reduce divide operations
Date: Fri, 21 Nov 2014 12:14:04 -0500	[thread overview]
Message-ID: <20141121171404.GR11522@wil.cx> (raw)
In-Reply-To: <alpine.LNX.2.00.1411211542000.4225@localhost.lm.intel.com>

On Fri, Nov 21, 2014@03:52:08PM +0000, Keith Busch wrote:
> On Fri, 21 Nov 2014, Matthew Wilcox wrote:
> >We could further optimise it by knowing that we need 0 pages if the I/O
> >is <= 8k in size:
> 
> I think that'll break if the first page has a non-zero offset, so
> we'd have to allow the overestimate if we want to keep this function
> simple. We could micro-optimize to return 0 if it's <= 4k, though.

Yes, sorry, you're right.

  reply	other threads:[~2014-11-21 17:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-20 22:13 [PATCH] NVMe: Reduce divide operations Sam Bradshaw
2014-11-20 23:41 ` Keith Busch
2014-11-21 17:36   ` Sam Bradshaw (sbradshaw)
2014-11-21 13:50 ` Matthew Wilcox
2014-11-21 15:52   ` Keith Busch
2014-11-21 17:14     ` Matthew Wilcox [this message]
2014-11-21 17:38   ` Sam Bradshaw (sbradshaw)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141121171404.GR11522@wil.cx \
    --to=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox