From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 04/11] nvme: remove the unused dma_addr_t arguments to nvme_{get, set}_features
Date: Sat, 9 May 2015 17:53:22 +0200 [thread overview]
Message-ID: <20150509155322.GA32628@lst.de> (raw)
In-Reply-To: <20150508190351.GM4003@linux.intel.com>
On Fri, May 08, 2015@03:03:51PM -0400, Matthew Wilcox wrote:
> > int nvme_get_features(struct nvme_dev *dev, unsigned fid, unsigned nsid,
> > - dma_addr_t dma_addr, u32 *result)
> > + u32 *result)
> > {
> > struct nvme_command c;
> >
> > memset(&c, 0, sizeof(c));
> > c.features.opcode = nvme_admin_get_features;
> > c.features.nsid = cpu_to_le32(nsid);
> > - c.features.prp1 = cpu_to_le64(dma_addr);
> > c.features.fid = cpu_to_le32(fid);
> >
> > return __nvme_submit_sync_cmd(dev->admin_q, &c, result, 0);
>
> Wait, what? The PRP1 field is used for LBA Range Type and Autonomous
> Power State Transitions.
None of which is, or ever was issued by the Linux driver.
next prev parent reply other threads:[~2015-05-09 15:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 16:00 nvme patchbomb, take 2 Christoph Hellwig
2015-05-08 16:00 ` [PATCH 01/11] nvme: fix kernel memory corruption with short INQUIRY buffers Christoph Hellwig
2015-05-13 14:34 ` Jens Axboe
2015-05-08 16:00 ` [PATCH 02/11] nvme: consolidate synchronous command submission helpers Christoph Hellwig
2015-05-08 16:00 ` [PATCH 03/11] nvme: store a struct device pointer in struct nvme_dev Christoph Hellwig
2015-05-08 16:00 ` [PATCH 04/11] nvme: remove the unused dma_addr_t arguments to nvme_{get, set}_features Christoph Hellwig
2015-05-08 19:03 ` Matthew Wilcox
2015-05-09 15:53 ` Christoph Hellwig [this message]
2015-05-11 13:54 ` Matthew Wilcox
2015-05-11 16:35 ` Keith Busch
2015-05-08 16:00 ` [PATCH 05/11] nvme: split nvme_trans_send_fw_cmd Christoph Hellwig
2015-05-08 16:00 ` [PATCH 06/11] nvme: fix scsi translation error handling Christoph Hellwig
2015-05-08 16:00 ` [PATCH 07/11] nvme: first round at deobsfucating the SCSI translation code Christoph Hellwig
2015-05-08 16:00 ` [PATCH 08/11] nvme: simplify and cleanup the READ/WRITE SCSI CDB parsing code Christoph Hellwig
2015-05-08 16:00 ` [PATCH 09/11] nvme: report the DPOFUA in MODE_SENSE Christoph Hellwig
2015-05-08 16:00 ` [PATCH 10/11] nvme: fail SCSI read/write command with unsupported protection bit Christoph Hellwig
2015-05-08 16:00 ` [PATCH 11/11] nvme: submit internal commands through the block layer Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150509155322.GA32628@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox