From: hch@lst.de (Christoph Hellwig)
Subject: nvme: submit internal commands through the block layer
Date: Wed, 27 May 2015 09:56:52 +0200 [thread overview]
Message-ID: <20150527075652.GA24737@lst.de> (raw)
In-Reply-To: <20150526090815.GA32137@mwanda>
On Tue, May 26, 2015@12:08:15PM +0300, Dan Carpenter wrote:
> drivers/block/nvme-core.c
> 853 */
> 854 if (ns && ns->ms && !blk_integrity_rq(req)) {
> ^^
> Patch adds a new check.
Correctly so ..
> 912 nvme_set_info(cmd, iod, req_completion);
> 913 spin_lock_irq(&nvmeq->q_lock);
> 914 if (req->cmd_type == REQ_TYPE_DRV_PRIV)
> 915 nvme_submit_priv(nvmeq, req, iod);
> 916 else if (req->cmd_flags & REQ_DISCARD)
> 917 nvme_submit_discard(nvmeq, ns, req, iod);
> ^^
> Dereferenced inside function.
>
> 918 else if (req->cmd_flags & REQ_FLUSH)
> 919 nvme_submit_flush(nvmeq, ns, req->tag);
We'll only get REQ_TYPE_DRV_PRIV requests through the passthrough
interface, so this is unrechable.
next parent reply other threads:[~2015-05-27 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150526090815.GA32137@mwanda>
2015-05-27 7:56 ` Christoph Hellwig [this message]
2015-05-27 10:47 ` nvme: submit internal commands through the block layer Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527075652.GA24737@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox