From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv2 1/2] blk-mq: Shared tag enhancements
Date: Wed, 3 Jun 2015 09:00:14 +0200 [thread overview]
Message-ID: <20150603070014.GD11344@lst.de> (raw)
In-Reply-To: <1433172594-32127-1-git-send-email-keith.busch@intel.com>
On Mon, Jun 01, 2015@09:29:53AM -0600, Keith Busch wrote:
> Storage controllers may expose multiple block devices that share hardware
> resources managed by blk-mq. This patch enhances the shared tags so a
> low-level driver can access the shared resources not tied to the unshared
> h/w contexts. This way the LLD can dynamically add and delete disks and
> request queues without having to track all the request_queue hctx's to
> iterate outstanding tags.
Why do you add a new function instead of fully replacing the old
blk_mq_tag_busy_iter? The only other user is the timeout handler,
and I think it would be fine with your version as well. And
blk_mq_tag_busy_iter is a much better name for your new function anyway :)
Also the patch is missing a description for the cpumask changes, which
look like they should be a separate patch, or probably just moved into
the driver as the blk core doesn't make use of it.
next prev parent reply other threads:[~2015-06-03 7:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 15:29 [PATCHv2 1/2] blk-mq: Shared tag enhancements Keith Busch
2015-06-01 15:29 ` [PATCHv2 2/2] NVMe: Remove hctx reliance for multi-namespace Keith Busch
2015-06-01 20:35 ` [PATCHv2 1/2] blk-mq: Shared tag enhancements Jens Axboe
2015-06-03 7:00 ` Christoph Hellwig [this message]
2015-06-03 14:14 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603070014.GD11344@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox