From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] NVMe: Fix IO for extended metadata formats
Date: Mon, 22 Jun 2015 17:39:00 +0200 [thread overview]
Message-ID: <20150622153900.GA7952@lst.de> (raw)
In-Reply-To: <B58D82457FDA0744A320A2FC5AC253B93CBA2D95@fmsmsx104.amr.corp.intel.com>
On Mon, Jun 22, 2015@03:17:07PM +0000, Busch, Keith wrote:
> Similar to SG_IO, we can submit arbitrary length commands using the nvme
> passthrough. It seems to work. Here's a test I did using the "nvme-cli"
> program.
Yeah, I was mostly worried about the request mapping code tripping
up on these unaligned sized. I don't have a device that supports it
so I couldn't test it myself.
Btw, given your test below: I had thought for a while to add unit
tests to the nvme-cli package for cases like the one you had below.
The use case would be mostly to verify the driver, less the hardware
unless the two are tangled up or the hardware specific cases are simple
enough. I've had good succeed with the cunit based SCSI testsuite
in libiscsi, so I could come up with a skeleton for it.
prev parent reply other threads:[~2015-06-22 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 17:07 [PATCH] NVMe: Fix IO for extended metadata formats Keith Busch
2015-06-19 19:16 ` Jens Axboe
2015-06-22 5:34 ` Christoph Hellwig
2015-06-22 15:17 ` Busch, Keith
2015-06-22 15:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622153900.GA7952@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox