From: jonathan.derrick@intel.com (Jon Derrick)
Subject: [PATCHv4 2/2] NVMe: Use CMB for the IO SQes if available
Date: Fri, 17 Jul 2015 09:46:32 -0600 [thread overview]
Message-ID: <20150717154632.GA3621@localhost.localdomain> (raw)
In-Reply-To: <20150717075123.GB31679@infradead.org>
> > +static int use_cmb_sqes = 1;
> > +module_param(use_cmb_sqes, int, 0644);
> > +MODULE_PARM_DESC(use_cmb_sqes, "use controller's memory buffer for I/O SQes");
>
> This should be a bool.
>
> > + }
> > +}
>
> Can you just return an error on allocation failure here insead of
> checking sq_cmds after the call to the function?
Will do. Thanks!
prev parent reply other threads:[~2015-07-17 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 22:51 [PATCHv4 0/2] NVMe: Enable SQes on the CMB Jon Derrick
2015-07-16 22:51 ` [PATCHv4 1/2] NVMe: Unify SQ entry writing and doorbell ringing Jon Derrick
2015-07-17 7:49 ` Christoph Hellwig
2015-07-16 22:51 ` [PATCHv4 2/2] NVMe: Use CMB for the IO SQes if available Jon Derrick
2015-07-17 7:51 ` Christoph Hellwig
2015-07-17 15:46 ` Jon Derrick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717154632.GA3621@localhost.localdomain \
--to=jonathan.derrick@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox