linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] Move nvme driver source into subdirectory and move pci specifics from core into separate file
Date: Thu, 24 Sep 2015 17:02:51 -0700	[thread overview]
Message-ID: <20150925000251.GA25904@infradead.org> (raw)
In-Reply-To: <1443130050.6973.125.camel@linux.intel.com>

Hi J,

thanks for starting this important work, but I think we need to do
this in smaller steps.  This large patch does a few things at the same
time:

 - move files to a new directory
 - split data structures
 - split files
 - introduces a new internal API

Which need to be split over a few patches.  I'd suggest we start with
the easiest and most important parts first and then iterate through the
rest.

My suggestion would be:

 a) move files to a new directory.  My suggestion for that would be
    driver/nvme/host/ as I have a software NVMe controller
    implementation under development which I'd like to also add under
    a different subdirectory of drivers/nvme.
 b) start splitting struct nvme_dev into a generic struct nvme_ctrl
    and a PCI-specific nvme_pci_ctrl

Based on that we can start thinking about an API and move the PCI code
to it's own file.  Note that most of your operations should not be
needed.  With my ongoing work we now have the nvme_submit*cmd* APIs
that give a nice separatation for anything related to NVMe commans,
so we'd just need abstractions for the BAR access.

  reply	other threads:[~2015-09-25  0:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 21:27 [PATCH] Move nvme driver source into subdirectory and move pci specifics from core into separate file J Freyensee
2015-09-25  0:02 ` Christoph Hellwig [this message]
2015-09-25 15:12   ` J Freyensee
2015-09-26 16:09     ` Christoph Hellwig
2015-09-26  5:32   ` Ming Lin
2015-09-26 16:11     ` Christoph Hellwig
2015-10-09 17:38       ` Ming Lin
2015-10-10  7:30         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150925000251.GA25904@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).