From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/7] nvme: delete dev from dev_list in nvme_reset
Date: Sat, 3 Oct 2015 12:01:59 +0200 [thread overview]
Message-ID: <20151003100159.GA851@lst.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1510022041060.23840@localhost.lm.intel.com>
On Fri, Oct 02, 2015@09:13:22PM +0000, Keith Busch wrote:
> A moment of panic when I saw this, but we're 'ok'. The reset handler calls
> nvme_dev_shutdown() first, and that removes the device from the list,
> so we won't really see a controller twice added in the list.
Oh. So we get a double list del there. I though list debuging would
complain about this. Anyway, let's make the deletion uniform and so that
any fixes can be applied to all callers in the same way.
next prev parent reply other threads:[~2015-10-03 10:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 17:58 nvme reset and probe updates Christoph Hellwig
2015-10-02 17:58 ` [PATCH 1/7] nvme: delete dev from dev_list in nvme_reset Christoph Hellwig
2015-10-02 21:13 ` Keith Busch
2015-10-03 10:01 ` Christoph Hellwig [this message]
2015-10-02 17:58 ` [PATCH 2/7] nvme: merge nvme_dev_reset into nvme_reset_failed_dev Christoph Hellwig
2015-10-02 21:15 ` Keith Busch
2015-10-02 17:58 ` [PATCH 3/7] nvme: factor reset code into a common helper Christoph Hellwig
2015-10-02 21:19 ` Keith Busch
2015-10-02 17:58 ` [PATCH 4/7] nvme: merge nvme_dev_start, nvme_dev_resume and nvme_async_probe Christoph Hellwig
2015-10-02 21:27 ` Keith Busch
2015-10-03 10:02 ` Christoph Hellwig
2015-10-02 17:58 ` [PATCH 5/7] nvme: remove duplicate call to nvme_set_irq_hints Christoph Hellwig
2015-10-02 17:58 ` [PATCH 6/7] nvme: properly handle partially initialized queues in nvme_create_io_queues Christoph Hellwig
2015-10-02 21:36 ` Keith Busch
2015-10-03 10:03 ` Christoph Hellwig
2015-10-02 17:58 ` [PATCH 7/7] nvme: remove failed controllers directly from probe/reset context Christoph Hellwig
2015-10-02 21:54 ` Keith Busch
2015-10-03 10:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151003100159.GA851@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).