From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/3] nvme: add missing unmaps in nvme_queue_rq
Date: Sat, 10 Oct 2015 08:55:14 +0200 [thread overview]
Message-ID: <20151010065514.GB17885@lst.de> (raw)
In-Reply-To: <561851EB.1070503@dev.mellanox.co.il>
On Sat, Oct 10, 2015@02:46:51AM +0300, Sagi Grimberg wrote:
> Would it be better to unmap the data sg once at error_cmd tag?
We'd need unmap versions of the error_cmd and retry_cmd goto labels,
which was too much churn for this quick fix. Patch 3 now has a single
exit path with a ret variable for the helper this has been factored out
to, so this has been taken care off there.
next prev parent reply other threads:[~2015-10-10 6:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 16:55 nvme ->queue_rq updates Christoph Hellwig
2015-10-09 16:55 ` [PATCH 1/3] nvme: add missing unmaps in nvme_queue_rq Christoph Hellwig
2015-10-09 23:46 ` Sagi Grimberg
2015-10-10 6:55 ` Christoph Hellwig [this message]
2015-10-09 16:55 ` [PATCH 2/3] nvme: simplify nvme_setup_prps calling convention Christoph Hellwig
2015-10-09 16:55 ` [PATCH 3/3] nvme: refactor nvme_queue_rq Christoph Hellwig
2015-10-09 20:11 ` Jon Derrick
2015-10-10 6:53 ` Christoph Hellwig
2015-10-10 7:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151010065514.GB17885@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox