From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvme: prepare support for Apple NVMe controller
Date: Tue, 3 Nov 2015 05:02:06 -0800 [thread overview]
Message-ID: <20151103130206.GA19495@infradead.org> (raw)
In-Reply-To: <20151029151056.GA2580@localhost.localdomain>
On Thu, Oct 29, 2015@09:10:56AM -0600, Jon Derrick wrote:
> > +#define readq lo_hi_readq
> > +#define writeq lo_hi_writeq
> > +
>
> Good job figuring that one out. But this should be a quirk:
> a) It will sacrifice some io cycles on other devices
> b) It may get lost at some point in the name of performance
>
> Christoph recently added a quirks mechanism where I think it would fit
We never access 64 bit registers in the fast path. I'd be fine to
apply the patch from Stephan as-is as long as we document in detail why
we are doing this. Stephan, can you respin the patch with a comment
and also with the PCI ID for the Apple controller added to the ID table?
next prev parent reply other threads:[~2015-11-03 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 14:38 [PATCH] nvme: prepare support for Apple NVMe controller Stephan Günther
2015-10-29 15:10 ` Jon Derrick
2015-10-29 16:36 ` Vedant Lath
2015-10-29 17:59 ` Stephan Günther
2015-10-31 22:34 ` Vedant Lath
2015-10-29 19:46 ` Stephan Günther
2015-10-29 20:31 ` Keith Busch
2015-10-29 20:41 ` Stephan Günther
2015-11-03 13:02 ` Christoph Hellwig [this message]
2015-11-03 20:43 ` Stephan Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103130206.GA19495@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).