From: keith.busch@intel.com (Keith Busch)
Subject: NVMe: Add persistent reservation ops
Date: Tue, 3 Nov 2015 15:39:58 +0000 [thread overview]
Message-ID: <20151103153958.GH13904@localhost.localdomain> (raw)
In-Reply-To: <20151103125815.GA5825@mwanda>
On Tue, Nov 03, 2015@03:58:15PM +0300, Dan Carpenter wrote:
>
> drivers/nvme/host/pci.c:2143 nvme_pr_clear()
> warn: suspicious bitop condition
>
> drivers/nvme/host/pci.c
> 2141 static int nvme_pr_clear(struct block_device *bdev, u64 key)
> 2142 {
> 2143 u32 cdw10 = 1 | key ? 1 << 3 : 0;
>
> Is this supposed to be?
>
> u32 cdw10 = 1 | (key ? 1 << 3 : 0);
>
> 2144 return nvme_pr_command(bdev, cdw10, key, 0, nvme_cmd_resv_register);
> 2145 }
Thanks for the catch. Must have pulled the patch from the wrong machine
when I added it to the persistent reservation series. Do you want to
send the fixing patch?
next parent reply other threads:[~2015-11-03 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151103125815.GA5825@mwanda>
2015-11-03 15:39 ` Keith Busch [this message]
2015-11-03 19:50 ` [patch] NVMe: Precedence error in nvme_pr_clear() Dan Carpenter
2015-11-03 19:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103153958.GH13904@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox