From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 09/12] nvme: properly free resources for cancelled command
Date: Mon, 16 Nov 2015 11:05:27 +0100 [thread overview]
Message-ID: <20151116100527.GA22867@lst.de> (raw)
In-Reply-To: <20151110202811.GA6506@localhost.localdomain>
On Tue, Nov 10, 2015@08:28:11PM +0000, Keith Busch wrote:
> > Perhaps I am thinking how probing serially worked before, and don't
> > understand how this works anymore. :)
> >
> > You're right, we don't really care anymore if the reset handler unwinds
> > it. This path is then safe to see a fake error code.
>
> Actually this still needs to be a negative error so nvme_reset_work
> doesn't clear "NVME_CTRL_RESETTING" bit. Without that, the driver gets
> in an infinite reset loop.
I don't think this is going to help as we'll never enter the reset loop
now that we have a single reset_work item, oops.
I guess we'll just need to set the aborted status from nvme_timeout
if we are in the reset handler already so that it can handle the
errors directly instead of waiting for another reset_work do be queued
up. I'll try to come up with a version of that.
next prev parent reply other threads:[~2015-11-16 10:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 8:44 nvme completion path optimizations and fixes V3 Christoph Hellwig
2015-11-07 8:44 ` [PATCH 01/12] block: fix blk_abort_request for blk-mq drivers Christoph Hellwig
2015-11-07 8:44 ` [PATCH 02/12] block: defer timeouts to a workqueue Christoph Hellwig
2015-11-07 8:44 ` [PATCH 03/12] nvme: factor out a nvme_unmap_data helper Christoph Hellwig
2015-11-09 18:47 ` Keith Busch
2015-11-09 18:56 ` Christoph Hellwig
2015-11-07 8:44 ` [PATCH 04/12] nvme: factor out a few helpers from req_completion Christoph Hellwig
2015-11-07 8:44 ` [PATCH 05/12] nvme: switch delete SQ/CQ to blk_execute_rq_nowait Christoph Hellwig
2015-11-07 8:45 ` [PATCH 06/12] nvme: switch abort " Christoph Hellwig
2015-11-09 21:33 ` Keith Busch
2015-11-09 21:46 ` Jens Axboe
2015-11-10 5:56 ` Christoph Hellwig
2015-11-07 8:45 ` [PATCH 07/12] nvme: special case AEN requests Christoph Hellwig
2015-11-09 21:43 ` Keith Busch
2015-11-09 21:48 ` Jens Axboe
2015-11-10 5:57 ` Christoph Hellwig
2015-11-07 8:45 ` [PATCH 08/12] nvme: simplify completion handling Christoph Hellwig
2015-11-07 8:45 ` [PATCH 09/12] nvme: properly free resources for cancelled command Christoph Hellwig
2015-11-09 18:57 ` Keith Busch
2015-11-09 19:25 ` Christoph Hellwig
2015-11-09 20:12 ` Keith Busch
2015-11-10 8:13 ` Christoph Hellwig
2015-11-10 16:03 ` Keith Busch
2015-11-10 20:28 ` Keith Busch
2015-11-16 10:05 ` Christoph Hellwig [this message]
2015-11-07 8:45 ` [PATCH 10/12] nvme: meta_sg doesn't have to be an array Christoph Hellwig
2015-11-07 8:45 ` [PATCH 11/12] nvme: merge iod and cmd_info Christoph Hellwig
2015-11-07 8:45 ` [PATCH 12/12] block: remove REQ_NO_TIMEOUT flag Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116100527.GA22867@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).