Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jonathan.derrick@intel.com (Jon Derrick)
Subject: [PATCH] nvme: allow queues the chance to quiesce after freezing them
Date: Thu, 19 Nov 2015 15:12:23 -0700	[thread overview]
Message-ID: <20151119221223.GA3516@localhost.localdomain> (raw)
In-Reply-To: <20151119214156.GA22690@localhost.localdomain>

> I think all we really want is skip notifying completions on a
> "suspended" queue. We can tell by the value of the cq-vector,
> and it's already lock protected.
> 
Good catch. I wish I had made that relationship :)
(Though I was hoping somebody would figure out a less hacky way of doing it than I did)

> It also sounds like we need to poll the cq after the delete completes
> to catch successful completions before we force cancel the rest.
>
> This appears to work for me. Does it pass your test?

Passes my tests as well so you can add my tb:
Tested-by: Jon Derrick <jonathan.derrick at intel.com>

Re: Christoph
>This looks reasonable.  I ran into stray ->q_db derference a lot during reset testing, but after my abort and reset rewrites ([1] for th latest
version) I couldn't reproduce it any more. 

Sorry this was against 4.3 (and was reproducible on 4.4-rc1). I will give your repo a test shortly

      parent reply	other threads:[~2015-11-19 22:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 19:11 [PATCH] nvme: allow queues the chance to quiesce after freezing them Jon Derrick
2015-11-19 20:53 ` Jon Derrick
2015-11-19 21:41 ` Keith Busch
2015-11-19 21:53   ` Christoph Hellwig
2015-11-19 22:20     ` Keith Busch
2015-11-19 22:24       ` Christoph Hellwig
2015-11-19 22:12   ` Jon Derrick [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151119221223.GA3516@localhost.localdomain \
    --to=jonathan.derrick@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox