From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: Allow controllers to specify a min queue depth for CMB
Date: Fri, 11 Dec 2015 21:06:53 +0100 [thread overview]
Message-ID: <20151211200653.GA26595@lst.de> (raw)
In-Reply-To: <1449862594-26103-1-git-send-email-jonathan.derrick@intel.com>
Hi Jon,
this patch confuses me for ? few reasons:
- please don't overload the quirks bitmap with actual values
- why do we even need to set a size instead of using up the CMB
size?
- why do we even need to add a quirk? I quick look at the spec
doesn't seem to require us to align the submission queue size
- this patchs adds a quirk, but no use of it so it's effectively just dead
code
next prev parent reply other threads:[~2015-12-11 20:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 19:36 [PATCH] nvme: Allow controllers to specify a min queue depth for CMB Jon Derrick
2015-12-11 20:06 ` Christoph Hellwig [this message]
2015-12-11 20:25 ` Jon Derrick
2015-12-11 20:33 ` Keith Busch
2015-12-11 20:59 ` Jon Derrick
2015-12-14 10:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211200653.GA26595@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox