From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv3 4/5] NVMe: IO queue deletion re-write
Date: Wed, 6 Jan 2016 19:51:12 +0000 [thread overview]
Message-ID: <20160106195112.GB20732@localhost.localdomain> (raw)
In-Reply-To: <20160106130419.GA23245@infradead.org>
On Wed, Jan 06, 2016@05:04:19AM -0800, Christoph Hellwig wrote:
> -static int nvme_delete_queue(struct nvme_queue *nvmeq, struct request_queue *q)
> +static int nvme_delete_queue(struct nvme_queue *nvmeq, u8 opcode)
> {
> + struct request_queue *q = nvmeq->dev->ctrl.admin_q;
> struct request *req;
> + struct nvme_command cmd;
>
> - req = nvme_alloc_request(q, (struct nvme_command *)&nvmeq->dq,
> - BLK_MQ_REQ_NOWAIT);
> + memset(&cmd, 0, sizeof(cmd));
> + cmd.delete_queue.opcode = nvme_admin_delete_sq;
Now I actually ran with the proposal and found this minor opcode
oversight. Should be:
+ cmd.delete_queue.opcode = opcode;
After that, it's successful.
next prev parent reply other threads:[~2016-01-06 19:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 16:10 [PATCHv3 0/5] NVMe fixes and updates, v3 Keith Busch
2016-01-04 16:10 ` [PATCHv3 1/5] NVMe: Fix admin queue ring wrap Keith Busch
2016-01-04 16:10 ` [PATCHv3 2/5] NVMe: Use a retryable error code on reset Keith Busch
2016-01-04 16:10 ` [PATCHv3 3/5] NVMe: Remove queue freezing on resets Keith Busch
2016-01-04 16:10 ` [PATCHv3 4/5] NVMe: IO queue deletion re-write Keith Busch
2016-01-06 13:04 ` Christoph Hellwig
2016-01-06 15:44 ` Keith Busch
2016-01-12 20:33 ` Jens Axboe
2016-01-06 19:51 ` Keith Busch [this message]
2016-01-07 18:54 ` Christoph Hellwig
2016-01-04 16:10 ` [PATCHv3 5/5] NVMe: Shutdown controller only for power-off Keith Busch
2016-01-04 16:36 ` [PATCHv3 0/5] NVMe fixes and updates, v3 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106195112.GB20732@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox