linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: snitzer@redhat.com (Mike Snitzer)
Subject: dm-multipath low performance with blk-mq
Date: Tue, 26 Jan 2016 08:29:39 -0500	[thread overview]
Message-ID: <20160126132939.GA23967@redhat.com> (raw)
In-Reply-To: <20160125233717.GQ24960@octiron.msp.redhat.com>

On Mon, Jan 25 2016 at  6:37pm -0500,
Benjamin Marzinski <bmarzins@redhat.com> wrote:

> On Mon, Jan 25, 2016@04:40:16PM -0500, Mike Snitzer wrote:
> > On Tue, Jan 19 2016 at  5:45P -0500,
> > Mike Snitzer <snitzer@redhat.com> wrote:
> 
> I don't think this is going to help __multipath_map() without some
> configuration changes.  Now that we're running on already merged
> requests instead of bios, the m->repeat_count is almost always set to 1,
> so we call the path_selector every time, which means that we'll always
> need the write lock. Bumping up the number of IOs we send before calling
> the path selector again will give this patch a change to do some good
> here.
> 
> To do that you need to set:
> 
> 	rr_min_io_rq <something_bigger_than_one>
> 
> in the defaults section of /etc/multipath.conf and then reload the
> multipathd service.
> 
> The patch should hopefully help in multipath_busy() regardless of the
> the rr_min_io_rq setting.

This patch, while generic, is meant to help the blk-mq case.  A blk-mq
request_queue doesn't have an elevator so the requests will not have
seen merging.

But yes, implied in the patch is the requirement to increase
m->repeat_count via multipathd's rr_min_io_rq (I'll backfill a proper
header once it is tested).

Thanks,
Mike

  reply	other threads:[~2016-01-26 13:29 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <569E11EA.8000305@dev.mellanox.co.il>
2016-01-19 22:45 ` dm-multipath low performance with blk-mq Mike Snitzer
2016-01-25 21:40   ` Mike Snitzer
2016-01-25 23:37     ` [dm-devel] " Benjamin Marzinski
2016-01-26 13:29       ` Mike Snitzer [this message]
     [not found]         ` <56A77C21.90605@suse.de>
2016-01-26 14:47           ` Mike Snitzer
2016-01-26 14:56             ` Christoph Hellwig
2016-01-26 15:27               ` Mike Snitzer
2016-01-27 11:14         ` Sagi Grimberg
2016-01-27 17:48           ` Mike Snitzer
2016-01-27 17:51             ` Jens Axboe
2016-01-27 18:16               ` Mike Snitzer
2016-01-27 18:26                 ` Jens Axboe
2016-01-27 19:14                   ` Mike Snitzer
2016-01-27 19:50                     ` Jens Axboe
2016-01-27 17:56             ` Sagi Grimberg
2016-01-27 18:42               ` Mike Snitzer
2016-01-27 19:49                 ` Jens Axboe
2016-01-27 20:45                   ` Mike Snitzer
2016-01-29 23:35               ` Mike Snitzer
2016-01-30  8:52                 ` Hannes Reinecke
2016-01-30 19:12                   ` Mike Snitzer
2016-02-01  6:46                     ` Hannes Reinecke
2016-02-03 18:04                       ` Mike Snitzer
2016-02-03 18:24                         ` Mike Snitzer
2016-02-03 19:22                           ` Mike Snitzer
2016-02-04  6:54                           ` Hannes Reinecke
2016-02-04 13:54                             ` Mike Snitzer
2016-02-04 13:58                               ` Hannes Reinecke
2016-02-04 14:09                                 ` Mike Snitzer
2016-02-04 14:32                                   ` Hannes Reinecke
2016-02-04 14:44                                     ` Mike Snitzer
2016-02-05 15:13                               ` [RFC PATCH] dm: fix excessive dm-mq context switching Mike Snitzer
2016-02-05 18:05                                 ` Mike Snitzer
2016-02-05 19:19                                   ` Mike Snitzer
2016-02-07 15:41                                     ` Sagi Grimberg
2016-02-07 16:07                                       ` Mike Snitzer
2016-02-07 16:42                                         ` Sagi Grimberg
2016-02-07 16:37                                       ` Bart Van Assche
2016-02-07 16:43                                         ` Sagi Grimberg
2016-02-07 16:53                                           ` Mike Snitzer
2016-02-07 16:54                                           ` Sagi Grimberg
2016-02-07 17:20                                             ` Mike Snitzer
2016-02-08 12:21                                               ` Sagi Grimberg
2016-02-08 14:34                                                 ` Mike Snitzer
2016-02-09  7:50                                               ` Hannes Reinecke
2016-02-09 14:55                                                 ` Mike Snitzer
2016-02-09 15:32                                                   ` Hannes Reinecke
2016-02-10  0:45                                                     ` Mike Snitzer
     [not found]                                                       ` <20160211015030.GA4481@redhat.com>
2016-02-11  3:35                                                         ` RCU-ified dm-mpath for testing/review Mike Snitzer
2016-02-11 15:34                                                         ` Mike Snitzer
2016-02-12 15:18                                                           ` Hannes Reinecke
2016-02-12 15:26                                                             ` Mike Snitzer
2016-02-12 16:04                                                               ` Hannes Reinecke
2016-02-12 18:00                                                                 ` Mike Snitzer
2016-02-15  6:47                                                                   ` Hannes Reinecke
2016-01-26  1:49     ` [dm-devel] dm-multipath low performance with blk-mq Benjamin Marzinski
2016-01-26 16:03     ` Mike Snitzer
2016-01-26 16:44       ` Christoph Hellwig
2016-01-27  2:09         ` Mike Snitzer
2016-01-27 11:10           ` Sagi Grimberg
2016-01-26 21:40       ` [dm-devel] " Benjamin Marzinski
2016-01-18 12:04 Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160126132939.GA23967@redhat.com \
    --to=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).