From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] NVMe: Make surprise removal work again
Date: Thu, 28 Jan 2016 14:55:50 +0000 [thread overview]
Message-ID: <20160128145550.GB3863@localhost.localdomain> (raw)
In-Reply-To: <56AA2A30.2040304@dev.mellanox.co.il>
On Thu, Jan 28, 2016@04:48:16PM +0200, Sagi Grimberg wrote:
> >That works only for active requests. There could be processes that entered
> >the queue and waiting for request tags to become available. These need
> >to be flushed to completion somehow ... maybe they shouldn't even succeed
> >in getting a request on a dying queue?
>
> Isn't that what blk_mq_wake_waiters() is for?
Yes, that'll wake processes waiting on tags, but not to their
demise. They'll get a tag and send it to the h/w context. We need to
start these back up so the driver can end those requests, or we need to
do something to end them at the block layer. It sounds like developers
are preferring the latter.
next prev parent reply other threads:[~2016-01-28 14:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 21:23 [PATCH 1/2] NVMe: Make surprise removal work again Keith Busch
2016-01-25 21:23 ` [PATCH 2/2] NVMe: Fix io incapable return values Keith Busch
2016-01-26 16:54 ` Christoph Hellwig
2016-01-26 18:11 ` Ming Lin
2016-01-27 11:19 ` Sagi Grimberg
2016-01-26 16:53 ` [PATCH 1/2] NVMe: Make surprise removal work again Christoph Hellwig
2016-01-26 23:59 ` Keith Busch
2016-01-27 11:47 ` Sagi Grimberg
2016-01-27 14:19 ` Keith Busch
2016-01-28 14:48 ` Sagi Grimberg
2016-01-28 14:55 ` Keith Busch [this message]
2016-01-28 15:20 ` Sagi Grimberg
2016-02-01 15:01 ` Wenbo Wang
2016-02-01 15:27 ` Busch, Keith
[not found] ` <B58D82457FDA0744A320A2FC5AC253B93D3D7E57@fmsmsx104.amr.corp.intel.com>
2016-02-02 1:17 ` Keith Busch
2016-02-02 2:41 ` Wenbo Wang
2016-02-02 5:29 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128145550.GB3863@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox