From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH v1 2/3] nvme: Use blk-mq helper for IO termination
Date: Thu, 4 Feb 2016 15:44:54 +0000 [thread overview]
Message-ID: <20160204154454.GB28747@localhost.localdomain> (raw)
In-Reply-To: <BJXPR01MB19990484665533561B21DB3E0D10@BJXPR01MB199.CHNPR01.prod.partner.outlook.cn>
On Thu, Feb 04, 2016@02:28:24PM +0000, Wenbo Wang wrote:
> Is the following execution valid?
>
> 1. request A is linked in q->request_list
q->request_list? Do you mean q->requeue_list?
> 2. device reset
> 3. all requests (including request A) are cancelled by nvme_dev_disable()->nvme_clear_queue()
If the request is on some list owned by the request_queue, it was not
started by the driver, and nvme_clear_queue doesn't do anything to it.
> 4. device restarted
> 5. flush q->request_list, and request A is again running in queue_rq. <-- since request A has been cancelled, it shall not be running again
Request A was not cancelled if it was never started. It will be submitted
when the driver restarts the queues h/w contexts.
Cancelling a command with the controller does not mean ending the request
in the block layer.
next prev parent reply other threads:[~2016-02-04 15:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 12:44 [PATCH RESEND v1 0/3] Move active IO termination to the core Sagi Grimberg
2016-02-02 12:44 ` [PATCH v1 1/3] blk-mq: Export tagset iter function Sagi Grimberg
2016-02-02 12:44 ` [PATCH v1 2/3] nvme: Use blk-mq helper for IO termination Sagi Grimberg
2016-02-02 16:32 ` Wenbo Wang
2016-02-02 16:49 ` Keith Busch
2016-02-03 0:35 ` Wenbo Wang
2016-02-03 1:26 ` Keith Busch
2016-02-04 14:28 ` Wenbo Wang
2016-02-04 15:44 ` Keith Busch [this message]
2016-02-05 6:53 ` Wenbo Wang
2016-02-02 12:44 ` [PATCH v1 3/3] blk-mq: Make blk_mq_all_tag_busy_iter static Sagi Grimberg
2016-02-10 10:12 ` [PATCH RESEND v1 0/3] Move active IO termination to the core Sagi Grimberg
2016-03-09 14:32 ` Christoph Hellwig
2016-03-09 15:57 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2016-01-10 8:59 [PATCH " Sagi Grimberg
2016-01-10 8:59 ` [PATCH v1 2/3] nvme: Use blk-mq helper for IO termination Sagi Grimberg
2016-01-15 16:48 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204154454.GB28747@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox