From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: do not touch sq door bell if nvmeq has been suspended
Date: Mon, 8 Feb 2016 15:01:33 +0000 [thread overview]
Message-ID: <20160208150132.GA25111@localhost.localdomain> (raw)
In-Reply-To: <BJXPR01MB19916231021454BD8731EBDE0D30@BJXPR01MB199.CHNPR01.prod.partner.outlook.cn>
On Sat, Feb 06, 2016@02:32:24PM +0000, Wenbo Wang wrote:
> Keith,
>
> Is the following solution OK?
> synchronize_rcu guarantee that no queue_rq is running concurrently with device disable code. Together with your another patch (adding blk_sync_queue), both sync/async path shall be handled correctly.
>
> Do you think synchronize_rcu shall be added to blk_sync_queue?
I was nearly going to suggest the same last week, but it feels wrong since
no one takes rcu_read_lock in the path we're trying to sychronoize. Is
this safe if the task is interrupted?
next prev parent reply other threads:[~2016-02-08 15:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 15:42 [PATCH] NVMe: do not touch sq door bell if nvmeq has been suspended Wenbo Wang
2016-02-01 15:59 ` Busch, Keith
2016-02-01 16:17 ` Wenbo Wang
2016-02-01 16:54 ` Jens Axboe
2016-02-02 7:15 ` Wenbo Wang
2016-02-02 12:41 ` Sagi Grimberg
2016-02-02 14:27 ` Keith Busch
2016-02-02 14:33 ` Sagi Grimberg
2016-02-02 14:46 ` Keith Busch
2016-02-02 17:20 ` Sagi Grimberg
2016-02-03 0:49 ` Wenbo Wang
2016-02-02 17:25 ` Keith Busch
2016-02-03 0:19 ` Wenbo Wang
2016-02-03 14:41 ` Keith Busch
2016-02-03 16:35 ` Wenbo Wang
2016-02-03 16:38 ` Keith Busch
2016-02-06 14:32 ` Wenbo Wang
2016-02-07 13:41 ` Sagi Grimberg
2016-02-08 15:01 ` Keith Busch [this message]
2016-02-09 11:22 ` Wenbo Wang
2016-02-09 22:55 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208150132.GA25111@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).