Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional
Date: Mon, 8 Feb 2016 15:12:58 +0000	[thread overview]
Message-ID: <20160208151258.GB25111@localhost.localdomain> (raw)
In-Reply-To: <20160208101350.GA32632@lst.de>

On Mon, Feb 08, 2016@11:13:50AM +0100, Christoph Hellwig wrote:
> On Mon, Feb 08, 2016@12:01:16PM +0200, Sagi Grimberg wrote:
> >
> >> Do we have defined sysfs attributes for NVMe devices nowadays?
> >
> > /sys/block/nvme0n1/uuid
> 
> That's only supported for NVMe 1.1 and higher devices, and optional.
> For older or stupid devices we need to support the algorithm based
> on the serial attribute from nvme_fill_device_id_scsi_string() in
> drivers/nvme/host/scsi.c.

It's even worse. NGUID was defined for 1.2 devices and higher. 1.1
devices should have EUI-64 at:
 
  /sys/block/nvmeXnY/eui

1.2 devices will have either uuid or eui (or both).

The majority of devices in circulation today are 1.0, and need to concat
these three entries to make a unique identifier:

  /sys/block/nvmeXnY/device/serial
  /sys/block/nvmeXnY/device/model
  /sys/block/nvmeXnY/nsid

  reply	other threads:[~2016-02-08 15:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-06 18:33 complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional James Bottomley
2016-02-07  9:22 ` Christoph Hellwig
2016-02-07 16:04   ` James Bottomley
2016-02-07 22:28     ` Jens Axboe
2016-02-07 23:07       ` James Bottomley
2016-02-08  7:24         ` Christoph Hellwig
2016-02-08  7:32         ` Hannes Reinecke
2016-02-08 10:01           ` Sagi Grimberg
2016-02-08 10:13             ` Christoph Hellwig
2016-02-08 15:12               ` Keith Busch [this message]
2016-02-08 15:19                 ` Hannes Reinecke
2016-02-08 16:15                   ` Keith Busch
2016-02-08 15:23           ` James Bottomley
2016-02-09 12:50       ` Christoph Hellwig
2016-02-09 13:29         ` Jens Axboe
2016-02-09 17:12           ` Christoph Hellwig
2016-02-09 17:14             ` Jens Axboe
2016-02-09 17:19               ` Christoph Hellwig
2016-02-09 17:19                 ` Jens Axboe
2016-02-09 15:37         ` James Bottomley
2016-02-08  7:26     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160208151258.GB25111@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox