linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/4] nvme: split dev_list_lock
Date: Tue, 9 Feb 2016 14:14:08 +0100	[thread overview]
Message-ID: <20160209131408.GA25813@lst.de> (raw)
In-Reply-To: <20160209124134.GM27969@c203.arch.suse.de>

On Tue, Feb 09, 2016@01:41:34PM +0100, Johannes Thumshirn wrote:
> On Mon, Feb 08, 2016@02:24:43PM -0800, Ming Lin wrote:
> > Split dev_list_lock into one in the core and one in the PCI driver.
> 
> The dev_list_lock in core.c doesn't really protect the dev_list, like it does
> in pci.c. Wouldn't it be better to rename it to something more appropriate? I
> just can't come up with a name, as it seems to be some kind of catch all lock.

I plans to remove the core.c dev_list_lock by rewriting the character
device interface code.  Let's keep the name for now, it'll go away.

(and the pci.c might be gone even sooner, but at least it has the right name
:))

  reply	other threads:[~2016-02-09 13:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 22:24 [PATCH 0/4] nvme: split pci module out of core module Ming Lin
2016-02-08 22:24 ` [PATCH 1/4] nvme: move timeout variables to core.c and export it Ming Lin
2016-02-09  9:25   ` Christoph Hellwig
2016-02-09 12:43   ` Johannes Thumshirn
2016-02-09 12:46   ` Matias Bjørling
2016-02-08 22:24 ` [PATCH 2/4] nvme: export more symbols Ming Lin
2016-02-09  9:25   ` Christoph Hellwig
2016-02-09 12:42   ` Johannes Thumshirn
2016-02-09 12:56   ` Matias Bjørling
2016-02-09 13:07     ` Christoph Hellwig
2016-02-08 22:24 ` [PATCH 3/4] nvme: split dev_list_lock Ming Lin
2016-02-09  9:26   ` Christoph Hellwig
2016-02-09 12:41   ` Johannes Thumshirn
2016-02-09 13:14     ` Christoph Hellwig [this message]
2016-02-09 13:34       ` Johannes Thumshirn
2016-02-08 22:24 ` [PATCH 4/4] nvme: split pci module out of core module Ming Lin
2016-02-09  8:56   ` Johannes Thumshirn
2016-02-09 18:26     ` Ming Lin
2016-02-10 13:35       ` Michal Marek
2016-02-09  9:26   ` Christoph Hellwig
2016-02-10  0:09     ` Ming Lin
2016-02-10 15:12   ` Keith Busch
2016-02-10 15:31     ` Ming Lin
2016-02-09  9:24 ` [PATCH 0/4] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160209131408.GA25813@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).