From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv2-4.5 00/10] NVMe fixes
Date: Thu, 11 Feb 2016 22:28:49 +0000 [thread overview]
Message-ID: <20160211222848.GA19595@localhost.localdomain> (raw)
In-Reply-To: <1455221147-24228-1-git-send-email-keith.busch@intel.com>
Just want to point out a couple issues. Both are easy fixes and will
send in a few minutes.
First, admin queues don't have namespaces, so the new namespace state
check isn't always correct. I haven't been able to synthesize a test that
gets an admin command down this path in the disabled queue condition,
but it's clearly not correct.
The second issue potentially existed all along, but it's a littlie easier
to hit now: we need to lock out shutdown from manipulating registers
while they're being setup. This was hit by forcing controller reset from
the shelll in a loop, then "rmmod nvme" at the same time.
next prev parent reply other threads:[~2016-02-11 22:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 20:05 [PATCHv2-4.5 00/10] NVMe fixes Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 01/10] blk-mq: End unstarted requests on dying queue Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 02/10] NVMe: Fix io incapable return values Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 03/10] NVMe: Allow request merges Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 04/10] NVMe: Fix namespace removal deadlock Keith Busch
2016-02-13 9:44 ` Christoph Hellwig
2016-02-11 20:05 ` [PATCHv2-4.5 05/10] NVMe: Requeue requests on suspended queues Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 06/10] NVMe: Poll device while still active during remove Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 07/10] NVMe: Simplify device reset failure Keith Busch
2016-02-13 9:21 ` Christoph Hellwig
2016-02-11 20:05 ` [PATCHv2-4.5 08/10] NVMe: Move error handling to failed reset handler Keith Busch
2016-02-13 9:46 ` Christoph Hellwig
2016-02-16 21:57 ` Keith Busch
2016-02-17 8:06 ` Christoph Hellwig
2016-02-11 20:05 ` [PATCHv2-4.5 09/10] NVMe: Mark queues as dead on degraded controller Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 10/10] NVMe: Rate limit nvme IO warnings Keith Busch
2016-02-12 8:16 ` Johannes Thumshirn
2016-02-11 22:28 ` Keith Busch [this message]
2016-02-11 22:38 ` [PATCHv2-4.5 00/10] NVMe fixes Jens Axboe
2016-02-12 8:35 ` Christoph Hellwig
2016-02-12 15:09 ` Jens Axboe
2016-02-12 15:24 ` Keith Busch
2016-02-13 9:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211222848.GA19595@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).