From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 1/2] NVMe: Lock out shutdown during pci init
Date: Tue, 16 Feb 2016 23:59:13 -0800 [thread overview]
Message-ID: <20160217075913.GA14303@infradead.org> (raw)
In-Reply-To: <20160216184046.GA8415@localhost.localdomain>
On Tue, Feb 16, 2016@06:40:47PM +0000, Keith Busch wrote:
> On Sat, Feb 13, 2016@01:58:51AM -0800, Christoph Hellwig wrote:
> > Seems like we should be holding the lock over the call
> > to nvme_dev_disable to get protection for the whole execution,
> > e.g. by adding a __nvme_dev_disable variant that expects the lock
> > to be held.
> >
> > Maybe it's also worth renaming shutdown_lock to register_mutex
> > or similar to better document what it protects.
>
> Perhaps we shouldn't unmap the registers on a reset. That'd fix several
> problems, including this one and writing queue doorbells.
I always thought there was a deep reason we'd need to unmap it. But
if there isn't getting rid of the unmap should make the driver a lot
more robust.
next prev parent reply other threads:[~2016-02-17 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 23:00 [PATCH 1/2] NVMe: Lock out shutdown during pci init Keith Busch
2016-02-11 23:00 ` [PATCH 2/2] NVMe: NULL pointer check for admin queues Keith Busch
2016-02-13 9:59 ` Christoph Hellwig
2016-02-22 8:44 ` Sagi Grimberg
2016-02-13 9:58 ` [PATCH 1/2] NVMe: Lock out shutdown during pci init Christoph Hellwig
2016-02-16 18:40 ` Keith Busch
2016-02-17 7:59 ` Christoph Hellwig [this message]
2016-02-17 13:40 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217075913.GA14303@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).