From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 2/3] nvme: don't poll the CQ from the kthread
Date: Wed, 17 Feb 2016 18:44:01 +0000 [thread overview]
Message-ID: <20160217184400.GD30059@localhost.localdomain> (raw)
In-Reply-To: <1455732194-30790-3-git-send-email-hch@lst.de>
On Wed, Feb 17, 2016@07:03:13PM +0100, Christoph Hellwig wrote:
> There is no reason to do unconditional polling of CQs per the NVMe
> spec.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
Looks good. Now we'll find out if anyone was unknowingly relying on
this. :)
The legacy IRQ used for the very first NVMe command after reset tripped
up some devices in the past, but the polling hid the breakage.
Reviewed-by: Keith Busch <keith.busch at intel.com>
next prev parent reply other threads:[~2016-02-17 18:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 18:03 nvme: remove the global device list and kthread Christoph Hellwig
2016-02-17 18:03 ` [PATCH 1/3] nvme: use a work item to submit async event requests Christoph Hellwig
2016-02-17 18:37 ` Keith Busch
2016-02-18 8:32 ` Johannes Thumshirn
2016-02-22 8:37 ` Sagi Grimberg
2016-02-17 18:03 ` [PATCH 2/3] nvme: don't poll the CQ from the kthread Christoph Hellwig
2016-02-17 18:44 ` Keith Busch [this message]
2016-02-18 8:34 ` Johannes Thumshirn
2016-02-22 8:38 ` Sagi Grimberg
2016-02-17 18:03 ` [PATCH 3/3] nvme: replace the kthread with a per-device watchdog timer Christoph Hellwig
2016-02-17 18:44 ` Keith Busch
2016-02-18 8:36 ` Johannes Thumshirn
2016-02-22 8:43 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217184400.GD30059@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox