linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH-4.5-v3 2/5] NVMe: Fix namespace removal deadlock
Date: Sun, 21 Feb 2016 08:17:14 -0800	[thread overview]
Message-ID: <20160221161714.GB21896@infradead.org> (raw)
In-Reply-To: <1455734215-20396-3-git-send-email-keith.busch@intel.com>

On Wed, Feb 17, 2016@11:36:52AM -0700, Keith Busch wrote:
> This patch makes nvme namespace removal lockless. It is up to the caller
> to ensure no active namespace scanning is occuring.

I wonder if it wouldn't be safer in the long run if we just switch
to RCU locking - that way we don't need any locks in the readers, they
can just grab a reference under rcu_read_lock(), and we don't need to
rely in implicit serialization for the updaters.

  parent reply	other threads:[~2016-02-21 16:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 18:36 [PATCH-4.5-v3 0/5] NVMe hot plug stuff Keith Busch
2016-02-17 18:36 ` [PATCH-4.5-v3 1/5] NVMe: Add controller removing state Keith Busch
2016-02-18  4:09   ` Christoph Hellwig
2016-02-18  9:37   ` Johannes Thumshirn
2016-02-17 18:36 ` [PATCH-4.5-v3 2/5] NVMe: Fix namespace removal deadlock Keith Busch
2016-02-18  2:00   ` Wenbo Wang
2016-02-18  4:09     ` Christoph Hellwig
2016-02-18 16:26       ` Keith Busch
2016-02-18  9:39   ` Johannes Thumshirn
2016-02-21 16:17   ` Christoph Hellwig [this message]
2016-02-17 18:36 ` [PATCH-4.5-v3 3/5] NVMe: Simplify device reset failure Keith Busch
2016-02-17 18:36 ` [PATCH-4.5-v3 4/5] NVMe: Move error handling to failed reset handler Keith Busch
2016-02-18  4:11   ` Christoph Hellwig
2016-02-18 19:38     ` Keith Busch
2016-02-18  9:42   ` Johannes Thumshirn
2016-02-17 18:36 ` [PATCH-4.5-v3 5/5] NVMe: Don't unmap controller registers on reset Keith Busch
2016-02-18  9:45   ` Johannes Thumshirn
2016-02-21 16:15   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160221161714.GB21896@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).