From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] NVMe: Use IDA for namespace disk naming
Date: Wed, 24 Feb 2016 11:33:29 -0800 [thread overview]
Message-ID: <20160224193329.GA25509@infradead.org> (raw)
In-Reply-To: <20160224145835.GA7494@localhost.localdomain>
On Wed, Feb 24, 2016@02:58:36PM +0000, Keith Busch wrote:
> On Wed, Feb 24, 2016@05:05:20AM -0800, Christoph Hellwig wrote:
> > But the bdi name embedds the major/minor of the device. So if we
> > haven't fully torn down the device we might run into sysfs name
> > conflicts.
>
> We don't tear down the minor until the final put_disk, fixing the
> major/minor lifetime issue. That was commit:
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2da78092dda13f1efd26edbbf99a567776913750
>
> The namespace's disk_name using the IDA is released in the same path as
> the final put_disk, so I think we're safe.
Ok, we should be fine then:
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2016-02-24 19:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 18:18 [PATCH] NVMe: Use IDA for namespace disk naming Keith Busch
2016-02-21 16:12 ` Christoph Hellwig
2016-02-23 22:56 ` Keith Busch
2016-02-24 13:05 ` Christoph Hellwig
2016-02-24 14:58 ` Keith Busch
2016-02-24 19:33 ` Christoph Hellwig [this message]
2016-02-22 8:54 ` Sagi Grimberg
2016-02-25 8:55 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224193329.GA25509@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox