From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/4] nvme: don't poll the CQ from the kthread
Date: Tue, 1 Mar 2016 09:49:38 +0100 [thread overview]
Message-ID: <20160301084938.GA1748@lst.de> (raw)
In-Reply-To: <20160229205607.GC3730@linux.intel.com>
On Mon, Feb 29, 2016@03:56:07PM -0500, Matthew Wilcox wrote:
> On Mon, Feb 29, 2016@03:59:45PM +0100, Christoph Hellwig wrote:
> > There is no reason to do unconditional polling of CQs per the NVMe
> > spec.
>
> Sure, per the spec there isn't. But in reality, devices ship with
> broken interrupt support. What's your plan for dealing with the bug
> reports from users who have misconfigured MSI support or IRQ lines that
> are routed to the wrong place? From my time maintaining SCSI drivers,
> this wasn't an uncommon bug report.
The same as for all other devices that have drivers without a dedicated
once per second polling loop? That is: fix the irq routing if possible
and find a specific workaround if really needed and required by
a blacklist instead of papering over it just in case.
next prev parent reply other threads:[~2016-03-01 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 14:59 roolup of my pending NVMe patches for 4.6 Christoph Hellwig
2016-02-29 14:59 ` [PATCH 1/4] nvme: use a work item to submit async event requests Christoph Hellwig
2016-02-29 14:59 ` [PATCH 2/4] nvme: don't poll the CQ from the kthread Christoph Hellwig
2016-02-29 20:56 ` Matthew Wilcox
2016-03-01 8:49 ` Christoph Hellwig [this message]
2016-02-29 14:59 ` [PATCH 3/4] nvme: replace the kthread with a per-device watchdog timer Christoph Hellwig
2016-02-29 14:59 ` [PATCH 4/4] nvme: return the whole CQE through the request passthrough interface Christoph Hellwig
2016-02-29 15:42 ` Keith Busch
2016-02-29 15:47 ` roolup of my pending NVMe patches for 4.6 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301084938.GA1748@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox