From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH v2 for-4.6 3/3] blk-mq: Make blk_mq_all_tag_busy_iter static
Date: Wed, 9 Mar 2016 20:54:36 +0000 [thread overview]
Message-ID: <20160309205436.GA22470@localhost.localdomain> (raw)
In-Reply-To: <1457544184-2838-4-git-send-email-sagig@mellanox.com>
On Wed, Mar 09, 2016@07:23:04PM +0200, Sagi Grimberg wrote:
> No caller outside the blk-mq code so we can settle
> with it static.
Hi Sagi,
The mtip32xx driver in linux-block/for-next is using
blk_mq_all_tag_busy_iter. This looks like the equivalent change for
that driver:
---
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 1c330b6..71bb370 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3000,14 +3000,14 @@ restart_eh:
"Completion workers still active!");
spin_lock(dd->queue->queue_lock);
- blk_mq_all_tag_busy_iter(*dd->tags.tags,
+ blk_mq_tagset_busy_iter(&dd->tags,
mtip_queue_cmd, dd);
spin_unlock(dd->queue->queue_lock);
set_bit(MTIP_PF_ISSUE_CMDS_BIT, &dd->port->flags);
if (mtip_device_reset(dd))
- blk_mq_all_tag_busy_iter(*dd->tags.tags,
+ blk_mq_tagset_busy_iter(&dd->tags,
mtip_abort_cmd, dd);
clear_bit(MTIP_PF_TO_ACTIVE_BIT, &dd->port->flags);
@@ -4175,7 +4175,7 @@ static int mtip_block_remove(struct driver_data *dd)
blk_mq_freeze_queue_start(dd->queue);
blk_mq_stop_hw_queues(dd->queue);
- blk_mq_all_tag_busy_iter(dd->tags.tags[0], mtip_no_dev_cleanup, dd);
+ blk_mq_tagset_busy_iter(&dd->tags, mtip_no_dev_cleanup, dd);
/*
* Delete our gendisk structure. This also removes the device
--
next prev parent reply other threads:[~2016-03-09 20:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 17:23 [PATCH v2 for-4.6 0/3] Provide better active I/O termination handlers Sagi Grimberg
2016-03-09 17:23 ` [PATCH v2 for-4.6 1/3] blk-mq: Export tagset iter function Sagi Grimberg
2016-03-10 8:33 ` Johannes Thumshirn
2016-03-09 17:23 ` [PATCH v2 for-4.6 2/3] nvme: Use blk-mq helper for IO termination Sagi Grimberg
2016-03-10 8:33 ` Johannes Thumshirn
2016-03-09 17:23 ` [PATCH v2 for-4.6 3/3] blk-mq: Make blk_mq_all_tag_busy_iter static Sagi Grimberg
2016-03-09 20:54 ` Keith Busch [this message]
2016-03-10 10:18 ` Sagi Grimberg
2016-03-10 8:38 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309205436.GA22470@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox