From: keith.busch@intel.com (Keith Busch)
Subject: guaranteed progress for NVME commands?
Date: Tue, 22 Mar 2016 14:46:16 +0000 [thread overview]
Message-ID: <20160322144615.GA24460@localhost.localdomain> (raw)
In-Reply-To: <20160322074531.GA32289@infradead.org>
On Tue, Mar 22, 2016@12:45:31AM -0700, Christoph Hellwig wrote:
> in SCSI and other block drivers we go through great pains to only
> use mempool backed allocations in the I/O path, so that we can make
> guaranteed progress for swap or the writeback daemons. But it seems
> like the NVMe driver is using plain kmalloc everywhere and seems to
> be getting away with that just for now. Is no one using swap on
> NVMe or am I missing a secret trick somewhere?
I believe swap reads and writes single pages, right? We only kmalloc if
we're transferring more than two pages.
... well, mostly. There are caveats if the host page size is greater than
the device's, but I'm not sure why the driver is even considering that.
The transfer size doesn't matter; only nr_phys_segments should determine how
many elements the nvme_iod sgl needs to have.
Anyway, our IO path's only malloc is the nvme_iod scatter list if it
doesn't fit inline. Is that sufficient for progress, or do you think
we need to follow a different example?
next prev parent reply other threads:[~2016-03-22 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 7:45 guaranteed progress for NVME commands? Christoph Hellwig
2016-03-22 14:46 ` Keith Busch [this message]
2016-03-22 17:57 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322144615.GA24460@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox