From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] Avoid reset work on watchdog timer function during error recovery
Date: Wed, 6 Apr 2016 20:50:23 +0000 [thread overview]
Message-ID: <20160406205023.GA4140@localhost.localdomain> (raw)
In-Reply-To: <1459974635-16178-1-git-send-email-gpiccoli@linux.vnet.ibm.com>
On Wed, Apr 06, 2016@05:30:35PM -0300, Guilherme G. Piccoli wrote:
> This patch adds a check on nvme_watchdog_timer() function to avoid the
> call to reset_work() when an error recovery process is ongoing on
> controller. The check is made by looking at pci_channel_offline()
> result.
>
> If we don't check for this on nvme_watchdog_timer(), error recovery
> mechanism can't recover well, because reset_work() won't be able to
> do its job (since we're in the middle of an error) and so the
> controller is removed from the system before error recovery mechanism
> can perform slot reset (which would allow the adapter to recover).
>
> Signed-off-by: Guilherme G. Piccoli <gpiccoli at linux.vnet.ibm.com>
Reviewed-by: Keith Busch <keith.busch at intel.com>
next prev parent reply other threads:[~2016-04-06 20:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 20:30 [PATCH] Avoid reset work on watchdog timer function during error recovery Guilherme G. Piccoli
2016-04-06 20:50 ` Keith Busch [this message]
2016-04-07 8:05 ` Johannes Thumshirn
2016-04-07 13:11 ` Christoph Hellwig
2016-04-07 13:17 ` Guilherme G. Piccoli
2016-04-07 13:18 ` Sagi Grimberg
2016-04-07 13:26 ` Christoph Hellwig
2016-04-07 14:24 ` Keith Busch
2016-04-07 15:42 ` Guilherme G. Piccoli
2016-04-07 15:46 ` Keith Busch
2016-04-07 16:03 ` Guilherme G. Piccoli
2016-04-12 19:01 ` Christoph Hellwig
2016-04-12 23:33 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406205023.GA4140@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox