From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] NVMe: Recognize the MacBook9,1 NVMe controller
Date: Mon, 23 May 2016 04:00:03 -0700 [thread overview]
Message-ID: <20160523110003.GD26331@infradead.org> (raw)
In-Reply-To: <20160516175209.GA21751@speicherleck.de>
> * some MacBook7,1 to avoid controller resets and data loss.
> + * For the controller found in the MacBook9,1 (device ID 0x2003), it
> + * seems that this workaround is not necessary.
No need for this comment.
> if (pdev->vendor == PCI_VENDOR_ID_APPLE && pdev->device == 0x2001) {
> dev->q_depth = 2;
> @@ -2181,6 +2183,7 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_IDENTIFY_CNS, },
> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> + { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) }, /* for the MacBook 9,1 */
But it might be worth to have a comment above these two entries like
/*
* Controller that don't use the NVMe class code:
*/
and skip the comment after your newly added entry.
Otherwise this looks fine:
Reviewed-by: Christoph Hellwig <hch at lst.de>
prev parent reply other threads:[~2016-05-23 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 17:52 [PATCH] NVMe: Recognize the MacBook9,1 NVMe controller Carina Willbold
2016-05-17 7:39 ` Johannes Thumshirn
2016-05-23 11:00 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523110003.GD26331@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox