From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCHv2] NVMe: Sync reset and scan work
Date: Fri, 27 May 2016 00:34:14 -0700 [thread overview]
Message-ID: <20160527073414.GA950@infradead.org> (raw)
In-Reply-To: <1464102370-11283-1-git-send-email-keith.busch@intel.com>
As mentioned before I like this a lot, but not that I looked into
porting this over to Fabrics I have a few more nitpicks..
- we really should go through nvme_reset_ctrl and thus the
nvme_reset_ctrl for all places that schedule a reset
- past that the transitions should be tightened so that we
can only transition from SCHED_RESET to RESETTING, and the
check for NVME_CTRL_RESETTING in the beginning of nvme_reset_work
can go away.
- isn't the flushing of the scan work better done from the
reset work so that we don't block the caller?
prev parent reply other threads:[~2016-05-27 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 15:06 [PATCHv2] NVMe: Sync reset and scan work Keith Busch
2016-05-24 15:59 ` Johannes Thumshirn
2016-05-24 21:39 ` Keith Busch
2016-05-25 8:15 ` Christoph Hellwig
2016-05-27 7:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527073414.GA950@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox