From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 1/2] NVMe: Add controller state for scheduling resets
Date: Tue, 31 May 2016 14:04:46 -0700 [thread overview]
Message-ID: <20160531210446.GA1338@infradead.org> (raw)
In-Reply-To: <1464724148-11169-1-git-send-email-keith.busch@intel.com>
> +int nvme_reset_ctrl(struct nvme_ctrl *ctrl)
> +{
> + if (!nvme_change_ctrl_state(ctrl, NVME_CTRL_SCHED_RESET))
> + return -EBUSY;
> +
> + return ctrl->ops->reset_ctrl(ctrl);
> +}
> +EXPORT_SYMBOL(nvme_reset_ctrl);
should be EXPORT_SYMBOL_GPL to match all the other symbols.
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch at lst.de>
prev parent reply other threads:[~2016-05-31 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 19:49 [PATCH 1/2] NVMe: Add controller state for scheduling resets Keith Busch
2016-05-31 19:49 ` [PATCH 2/2] NVMe: Synchronize resets with scan work Keith Busch
2016-05-31 21:05 ` Christoph Hellwig
2016-06-01 7:20 ` Johannes Thumshirn
2016-05-31 21:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531210446.GA1338@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox