From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH v2] NVMe: Add controller state for scheduling resets
Date: Tue, 31 May 2016 17:31:18 -0400 [thread overview]
Message-ID: <20160531213118.GF24107@localhost.localdomain> (raw)
In-Reply-To: <1464729484-14424-1-git-send-email-keith.busch@intel.com>
On Tue, May 31, 2016@03:18:04PM -0600, Keith Busch wrote:
> /* Skip controllers under certain specific conditions. */
> if (nvme_should_reset(dev, csts)) {
> - if (queue_work(nvme_workq, &dev->reset_work))
> + if (nvme_reset_ctrl(&dev->ctrl))
> dev_warn(dev->dev,
> "Failed status: 0x%x, reset controller.\n",
> csts);
err, that condition should be !nvme_reset_ctrl since it returns 0 on
success rather than the status of queue_work. It still does correctly
resets the controller, but we miss the very useful warning message. Let
me send a v3...
next prev parent reply other threads:[~2016-05-31 21:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 21:18 [PATCH v2] NVMe: Add controller state for scheduling resets Keith Busch
2016-05-31 21:31 ` Keith Busch [this message]
2016-06-08 11:59 ` Sagi Grimberg
2016-06-08 12:03 ` Christoph Hellwig
2016-06-08 12:11 ` Sagi Grimberg
2016-06-08 13:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531213118.GF24107@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox