From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH v3] NVMe: Add controller state for scheduling resets
Date: Wed, 1 Jun 2016 01:03:49 -0700 [thread overview]
Message-ID: <20160601080349.GA20479@infradead.org> (raw)
In-Reply-To: <201605312323.u4VNDrlk028002@mx0a-001b2d01.pphosted.com>
On Tue, May 31, 2016@08:23:36PM -0300, Guilherme G. Piccoli wrote:
> On 05/31/2016 08:05 PM, Keith Busch wrote:
> >On Tue, May 31, 2016@07:24:48PM -0300, Guilherme G. Piccoli wrote:
> >>But imagine a scenario I have multiple nvme devices and want to upgrade the
> >>firmware for only one. In this case, the procedure is to reset_controller
> >>only the specific device after the fw activation.
> >>modprobe the driver in this case it too much.
> >
> >I agree module reload would be heavy handed in your scenario, but just
> >trying to establish what conditions you really need the quirk to work.
>
> Only in reset_controller after a firmware activation. The quirk
> implementation was delaying all reset_controller calls though.
Only doing it after the firmware activation would be nice, but the
only way to detect this reliably would be to check for the firmware
activation command in the passthrough path. And that really seems to
be a bit too ugly.
next prev parent reply other threads:[~2016-06-01 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 21:25 [PATCH v3] NVMe: Add controller state for scheduling resets Keith Busch
2016-05-31 22:10 ` Guilherme G. Piccoli
[not found] ` <201605312210.u4VM8qNZ046737@mx0a-001b2d01.pphosted.com>
2016-05-31 22:26 ` Keith Busch
2016-05-31 22:24 ` Guilherme G. Piccoli
[not found] ` <201605312224.u4VMNvZS024236@mx0a-001b2d01.pphosted.com>
2016-05-31 23:05 ` Keith Busch
2016-05-31 23:23 ` Guilherme G. Piccoli
2016-06-01 8:03 ` Christoph Hellwig [this message]
2016-06-01 13:29 ` Guilherme G. Piccoli
2016-06-01 7:21 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601080349.GA20479@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox