From: keith.busch@intel.com (Keith Busch)
Subject: Question on Patch - NVMe: Shutdown controller only for power-off
Date: Tue, 7 Jun 2016 14:55:45 -0400 [thread overview]
Message-ID: <20160607185545.GF28414@localhost.localdomain> (raw)
In-Reply-To: <BL2PR04MB163077C4D3CD0E5075DF8E3925D0@BL2PR04MB163.namprd04.prod.outlook.com>
On Tue, Jun 07, 2016@06:42:00PM +0000, Jeff Lien wrote:
> Keith,
> The issue isn't that the fw activate requires a shutdown; it's more that the HGST controller takes much longer to execute the nvme_disable_ctrl if it hasn't been shutdown first. This issue caused us to add a longer delay before the first read of the csts reg in nvme_wait_ready.
>
> Rather than adding a delay in nvme_disable_controller, I think the better option would be to shutdown the controller. The comment says "If we're called to reset a live controller first shut it down" so in this case I think the shutdown parm should be true.
I'll change the comment to say "disable" instead of "shut down". We
want to reserve controller shutdown to power loss scenarios per spec
recommendations, which this is not. A controller reset is generally much
faster than a shutdown, which is why we don't toggle CC.SHN here.
prev parent reply other threads:[~2016-06-07 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BL2PR04MB163B82FED551339CEDC2116925D0@BL2PR04MB163.namprd04.prod.outlook.com>
2016-06-07 17:45 ` Fw: Question on Patch - NVMe: Shutdown controller only for power-off Jeff Lien
2016-06-07 17:58 ` Keith Busch
2016-06-07 18:42 ` Jeff Lien
2016-06-07 18:55 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607185545.GF28414@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox