From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-rdma: Always signal fabrics private commands
Date: Tue, 28 Jun 2016 10:41:05 +0200 [thread overview]
Message-ID: <20160628084105.GA13533@lst.de> (raw)
In-Reply-To: <577005C3.4000802@grimberg.me>
On Sun, Jun 26, 2016@07:41:39PM +0300, Sagi Grimberg wrote:
> Our error path is freeing the tagset before we free the queue (draining
> the qp) so we get to a use-after-free condition (->done() is a freed
> tag memory).
>
> Note that we must allocate the qp before we allocate the tagset because
> we need the device when init_request callouts come. So we allocated
> before, we free after. An alternative fix was to free the queue before
> the tagset even though we allocated it before (as Steve suggested).
Would draining, but not freeing the qp before freeing the tagset work?
That seems like the most sensible option here.
next prev parent reply other threads:[~2016-06-28 8:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 16:08 [PATCH] nvme-rdma: Always signal fabrics private commands Sagi Grimberg
2016-06-23 18:17 ` Steve Wise
2016-06-24 7:07 ` Christoph Hellwig
2016-06-24 14:05 ` Steve Wise
2016-06-26 16:41 ` Sagi Grimberg
2016-06-28 8:41 ` Christoph Hellwig [this message]
2016-06-28 14:20 ` Steve Wise
2016-06-29 14:57 ` Steve Wise
2016-06-30 6:36 ` 'Christoph Hellwig'
2016-06-30 13:44 ` Steve Wise
2016-06-30 15:10 ` Steve Wise
2016-07-13 10:08 ` Sagi Grimberg
2016-07-13 10:11 ` Sagi Grimberg
2016-07-13 14:28 ` Steve Wise
2016-07-13 14:47 ` Sagi Grimberg
2016-07-13 14:51 ` Steve Wise
2016-07-13 15:02 ` Sagi Grimberg
2016-07-13 15:12 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628084105.GA13533@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).