From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv2 1/3] nvme: Remove RCU namespace protection
Date: Thu, 30 Jun 2016 10:57:51 -0400 [thread overview]
Message-ID: <20160630145750.GC13842@localhost.localdomain> (raw)
In-Reply-To: <20160630064838.GA1608@infradead.org>
On Wed, Jun 29, 2016@11:48:38PM -0700, Christoph Hellwig wrote:
> But we remove it from the list before del_gendisk in
> nvme_remove_invalid_namespaces and nvme_scan_ns_list already. I guess
> that's fine because we're not going to do I/O on them at this point,
Right, we can safely remove them from the list for those other cases
precisely because they can't do IO anymore.
> but what prevents us form doing this two step removal in
> nvme_remove_namespaces?
If the controller fails during del_gendisk, we have to kill all
the request queues and set capacities to 0 to force del_gendisk to
complete. If the namespace isn't in the ctrl->namespace list, the driver
can't find the namespace to kill.
next prev parent reply other threads:[~2016-06-30 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 17:29 [PATCH 0/3] Namespace iteration fixes Keith Busch
2016-06-23 17:29 ` [PATCHv2 1/3] nvme: Remove RCU namespace protection Keith Busch
2016-06-28 8:31 ` Christoph Hellwig
2016-06-28 16:35 ` Keith Busch
2016-06-30 6:48 ` Christoph Hellwig
2016-06-30 14:57 ` Keith Busch [this message]
2016-06-30 22:59 ` Keith Busch
2016-06-23 17:29 ` [PATCH 2/3] nvme: Kill detached namespaces prior to removal Keith Busch
2016-06-28 8:32 ` Christoph Hellwig
2016-06-23 17:29 ` [PATCH 3/3] nvme: Put invalid namespaces on removal list Keith Busch
2016-06-28 8:32 ` Christoph Hellwig
2016-06-23 17:44 ` [PATCH 0/3] Namespace iteration fixes Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630145750.GC13842@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).