From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v3] nvmet-rdma: Correctly handle RDMA device hot removal
Date: Mon, 1 Aug 2016 13:15:30 +0200 [thread overview]
Message-ID: <20160801111530.GB16474@lst.de> (raw)
In-Reply-To: <1469967347-20466-1-git-send-email-sagi@grimberg.me>
This looks reasonable to me, but a little question below:
> @@ -1442,7 +1491,8 @@ static void nvmet_rdma_remove_port(struct nvmet_port *port)
> {
> struct rdma_cm_id *cm_id = port->priv;
>
> - rdma_destroy_id(cm_id);
> + if (cm_id)
> + rdma_destroy_id(cm_id);
> }
How is ->remove_port synchronized vs the RDMA/CM even handler?
next prev parent reply other threads:[~2016-08-01 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 12:15 [PATCH v3] nvmet-rdma: Correctly handle RDMA device hot removal Sagi Grimberg
2016-08-01 11:15 ` Christoph Hellwig [this message]
2016-08-01 11:30 ` Sagi Grimberg
2016-08-01 15:50 ` Christoph Hellwig
2016-08-02 6:39 ` Sagi Grimberg
2016-08-02 12:53 ` Christoph Hellwig
2016-08-01 14:44 ` Bart Van Assche
2016-08-01 15:09 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801111530.GB16474@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).