From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Tue, 2 Aug 2016 14:52:57 +0200 Subject: [PATCH 3/5] nvme-rdma: Make sure to shutdown the controller if we can In-Reply-To: References: <1469822242-3477-1-git-send-email-sagi@grimberg.me> <1469822242-3477-4-git-send-email-sagi@grimberg.me> <20160801110446.GD16141@lst.de> <63b33585-3fd2-a497-94a1-34dc9484da99@grimberg.me> <20160801154840.GB22771@lst.de> Message-ID: <20160802125257.GD13235@lst.de> On Tue, Aug 02, 2016@09:19:56AM +0300, Sagi Grimberg wrote: >> I don't want ->queue_rq to peek at controller state. What I had >> in mind was copying the PCIe behavior of failing early in the >> timeout handler if we are in the reset handler, which will >> mean blk_execute_rq will return ASAP with an error. > > Do we want the unnecessary ADMIN_TIMEOUT for sending a shutdown > on a queue we know is not connected? I'm worried it will have scale > issues... Allright, let's go with your version.