* [PATCH] nvme-rdma: start async event handler after reconnecting to a controller
@ 2016-08-04 10:51 Sagi Grimberg
2016-08-04 11:51 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Sagi Grimberg @ 2016-08-04 10:51 UTC (permalink / raw)
When we reset or reconnect to a controller, we are cancelling the
async event handler so we can safely re-establish resources, but we
need to remember to start it again when we successfully reconnect.
Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
---
drivers/nvme/host/rdma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 6378dc94aeaf..f2cf433f628d 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -745,6 +745,7 @@ static void nvme_rdma_reconnect_ctrl_work(struct work_struct *work)
if (ctrl->queue_count > 1) {
nvme_start_queues(&ctrl->ctrl);
nvme_queue_scan(&ctrl->ctrl);
+ nvme_queue_async_events(&ctrl->ctrl);
}
dev_info(ctrl->ctrl.device, "Successfully reconnected\n");
@@ -1747,6 +1748,7 @@ static void nvme_rdma_reset_ctrl_work(struct work_struct *work)
if (ctrl->queue_count > 1) {
nvme_start_queues(&ctrl->ctrl);
nvme_queue_scan(&ctrl->ctrl);
+ nvme_queue_async_events(&ctrl->ctrl);
}
return;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] nvme-rdma: start async event handler after reconnecting to a controller
2016-08-04 10:51 [PATCH] nvme-rdma: start async event handler after reconnecting to a controller Sagi Grimberg
@ 2016-08-04 11:51 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2016-08-04 11:51 UTC (permalink / raw)
On Thu, Aug 04, 2016@01:51:16PM +0300, Sagi Grimberg wrote:
> When we reset or reconnect to a controller, we are cancelling the
> async event handler so we can safely re-establish resources, but we
> need to remember to start it again when we successfully reconnect.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
Looks fine:
Reviewed-by: Christoph Hellwig <hch at lst.de>
We'll also need an equivalent for the loop driver I think.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-04 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-04 10:51 [PATCH] nvme-rdma: start async event handler after reconnecting to a controller Sagi Grimberg
2016-08-04 11:51 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).