From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/2] nvme-rdma: sqsize/hsqsize/hrqsize is 0-based val
Date: Mon, 8 Aug 2016 09:06:20 +0200 [thread overview]
Message-ID: <20160808070620.GB12902@lst.de> (raw)
In-Reply-To: <8bca04d5-8793-5bc3-9a18-4a7f66af40cc@grimberg.me>
On Sun, Aug 07, 2016@10:29:08AM +0300, Sagi Grimberg wrote:
> Did we really decide that? The spec actually explicitly says
> that a 0 sqsize will be failed:
>
> "If the size is 0h or larger than the controller supports, then a
> status value of Connect Invalid Parameters shall be returned."
>
> And then it says: "This is a 0?s based value"
>
> Confusing....
Yeah, I think we'll need an errate in the TWG. And I think the
current Linux behavior is the sensible one. Jay, do you want
to drive this in the WG or I should I bring it up?
next prev parent reply other threads:[~2016-08-08 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 0:54 [PATCH 0/2] nvme-fabrics: sqsize bug fixes Jay Freyensee
2016-08-06 0:54 ` [PATCH 1/2] nvme-rdma: tell fabrics layer admin queue depth Jay Freyensee
2016-08-07 7:20 ` Sagi Grimberg
2016-08-08 7:05 ` Christoph Hellwig
2016-08-08 16:11 ` J Freyensee
2016-08-06 0:54 ` [PATCH 2/2] nvme-rdma: sqsize/hsqsize/hrqsize is 0-based val Jay Freyensee
2016-08-07 7:29 ` Sagi Grimberg
2016-08-08 7:06 ` Christoph Hellwig [this message]
2016-08-08 16:30 ` Verkamp, Daniel
[not found] ` <9A947B1F6D0FF74CB5D6ACFF43B473F3A3A45C75@ORSMSX112.amr.corp.intel.com>
2016-08-08 18:39 ` J Freyensee
2016-08-08 16:08 ` Verkamp, Daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808070620.GB12902@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).