From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v3 1/4] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize
Date: Wed, 17 Aug 2016 02:47:13 +0200 [thread overview]
Message-ID: <20160817004713.GA21992@lst.de> (raw)
In-Reply-To: <1471377415-29337-2-git-send-email-james_p_freyensee@linux.intel.com>
On Tue, Aug 16, 2016@12:56:52PM -0700, Jay Freyensee wrote:
> /*
> - * req->hsqsize corresponds to our recv queue size
> - * req->hrqsize corresponds to our send queue size
> + * req->hsqsize corresponds to our recv queue size plus 1
> + * req->hrqsize corresponds to our send queue size plus 1
> */
> - queue->recv_queue_size = le16_to_cpu(req->hsqsize);
> - queue->send_queue_size = le16_to_cpu(req->hrqsize);
> + queue->recv_queue_size = le16_to_cpu(req->hsqsize) + 1;
> + queue->send_queue_size = le16_to_cpu(req->hrqsize) + 1;
I brought this up on the nvme-technical list and the consensus is
that hrqsize doesn't use the one off notation. hsqsize refers to
the sqsize which is marked as "0's based", while hrqsize only
has a short and not very meaningful explanation, which implies that
it's '1's based' in NVMe terms (which, btw I think are utterly misleading).
next prev parent reply other threads:[~2016-08-17 0:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 19:56 [PATCH v3 0/4] sqsize fixes Jay Freyensee
2016-08-16 19:56 ` [PATCH v3 1/4] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize Jay Freyensee
2016-08-17 0:47 ` Christoph Hellwig [this message]
2016-08-17 14:49 ` Sagi Grimberg
2016-08-17 15:47 ` J Freyensee
2016-08-17 18:36 ` Sagi Grimberg
2016-08-17 18:51 ` J Freyensee
2016-08-16 19:56 ` [PATCH v3 2/4] fabrics: define admin sqsize min default, per spec Jay Freyensee
2016-08-16 19:56 ` [PATCH v3 3/4] nvme-rdma: fix sqsize/hsqsize " Jay Freyensee
2016-08-16 19:56 ` [PATCH v3 4/4] nvme-loop: set sqsize to 0-based value, " Jay Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817004713.GA21992@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).